happy-dom icon indicating copy to clipboard operation
happy-dom copied to clipboard

Published 20 hours ago • verified publisher icon capricorn86

URL is missing searchParams

Open oytuntez opened this issue 2 years ago • 1 comments

Hi there!

Thank you for the effort in this library – I am testing happy-dom to see if I can achieve some performance improvement over jsdom. Our case is more of a server-side rendering: we have a browser library that manipulates the existing DOM very very heavily (mutation observers, tree walkers, attribute modifications, node additions/removals etc). JSDom spends a lot of time in various places.

While testing happy-dom, I am encountering several things, I will be submitting them as issues here as I see them. Here is the first one.

URL object does not have a searchParams property, only search: https://developer.mozilla.org/en-US/docs/Web/API/URL/searchParams

oytuntez avatar Apr 10 '22 13:04 oytuntez

@Mas0nShi is fixing this in this PR 🙂

https://github.com/capricorn86/happy-dom/pull/520

capricorn86 avatar Jul 01 '22 13:07 capricorn86

Is there any update on this?

jackdomleo7 avatar Sep 26 '22 15:09 jackdomleo7

It looks like progress is on-going in that PR, but it's a pretty big change. I could put together a PR that just replaces URL.ts with node's built-in "url" module.

kevinbarabash avatar Nov 05 '22 16:11 kevinbarabash

@oytuntez @jackdomleo7 @kevinbarabash A fix has now been released :slightly_smiling_face:

You can read more about the release here: https://github.com/capricorn86/happy-dom/releases/tag/v7.8.0

capricorn86 avatar Dec 07 '22 18:12 capricorn86