vlcj icon indicating copy to clipboard operation
vlcj copied to clipboard

Consider reinstating finished event after end reached was changed to stopping

Open caprica opened this issue 2 years ago • 5 comments

The native event manager changed end reached to stopping.

vlcj used end reached for its finished event.

Since stopping does not seem semantically the same as finished, the event was changed in vlcj also.

But it would be better to keep the finished event in vlcj if that is possible.

caprica avatar Apr 10 '22 16:04 caprica

This is actually tricky.

The stopped event may occur whether the media finished or not - but it is (probably) the most common use-case to know when media actually finished (so the next one can be played).

caprica avatar Apr 10 '22 17:04 caprica

This is complicated by the fact that "stopping" now seems to be raised whether the media reached the end or was explicitly stopped - so how do you determine the difference? In this sense, stopping is NOT a compatible replacement for end reached.

caprica avatar Apr 10 '22 17:04 caprica

Related to #1133.

caprica avatar Apr 10 '22 17:04 caprica

https://code.videolan.org/videolan/vlc/-/issues/26819 cross-tracking.

mfkl avatar Apr 28 '22 02:04 mfkl

Remember to update README as this is currently called out as a backwards-incompatible API change.

caprica avatar May 29 '22 10:05 caprica