pycapnp icon indicating copy to clipboard operation
pycapnp copied to clipboard

Published 20 hours ago • verified publisher icon capnproto

Improve LGTM C/C++ code rating

Open haata opened this issue 4 years ago • 1 comments

Python is currently A+. There's no reason why the C/C++ code can't be just as high.

haata avatar Jun 01 '21 15:06 haata

lgtm C++ is giving a rating of "C".

The only lgtm C++ alert is about

No matching copy assignment operator in class PyRefCounter. It is good practice to match a copy constructor with a copy assignment operator.

Maybe try fixing that and see what happens?

https://lgtm.com/help/lgtm/cpp-extraction says only SCons, WAF, Ninja, or Make are supported automatic builders. Perhaps we need to create a lgtm.yml with steps to build, so that it can give a higher score?

jayvdb avatar Jun 02 '21 21:06 jayvdb