node-capnp icon indicating copy to clipboard operation
node-capnp copied to clipboard

Add GitHub Actions CI test

Open haata opened this issue 3 years ago • 5 comments

Very basic GitHub Actions configuration.

haata avatar Nov 22 '20 06:11 haata

Thanks for writing this!

I wonder why the action didn't actually run on this PR itself? It would be nice to see that it passes before merging. I was under the impression that PRs were allowed to modify workflows, and those modifications would actually be used when running the workflow on the PR, so I don't get why it's not happening here.

I wonder if node.js is possibly not a valid action name, because it contains a .... I would name it just test.

kentonv avatar Nov 30 '20 22:11 kentonv

Yeah, I'm not sure how the Actions stuff works for PRs. I think there's some sort of approval process to even enable actions (so you don't just get random PRs running code for actions, but I'm not too sure). The Actions work on my own fork, so I know they run https://github.com/haata/node-capnp/actions.

I still need to do some work on the Windows version of this, haven't been able to get it to compile yet. Will post a separate PR when it's ready.

haata avatar Nov 30 '20 23:11 haata

I am thinking it'll only run on a PR where the branch name is node10...

Actions shouldn't need any permission to run, it's just that Actions on PRs can't access secrets, generally.

ocdtrekkie avatar Nov 30 '20 23:11 ocdtrekkie

Sandstorm's is just on: [push, pull_request] and I think that probably would work fine here.

ocdtrekkie avatar Nov 30 '20 23:11 ocdtrekkie

I made the change, still doesn't seem to show up here. Again, works on my branch: https://github.com/haata/node-capnp/actions/runs/393176929

haata avatar Dec 01 '20 05:12 haata