capnproto-rust icon indicating copy to clipboard operation
capnproto-rust copied to clipboard

Make `IndexMove` private and unsafely implement it for all lists

Open marmeladema opened this issue 3 years ago • 1 comments

In some sense it acts as a get_unchecked method but is not exposed publicly anymore to prevent rogue implementations.

marmeladema avatar Sep 02 '22 21:09 marmeladema

If I understand correctly, the purpose of this is to make it so that iterator-based access to capnproto lists avoids bounds checks. Have you experimentally observed a significant improvement from this change? I'm somewhat reluctant to add more instances of unsafe like this.

dwrensha avatar Nov 01 '22 12:11 dwrensha