react-native-pathjs-charts icon indicating copy to clipboard operation
react-native-pathjs-charts copied to clipboard

Line Chart with circles

Open ibrahimahmed-io opened this issue 8 years ago • 6 comments

Can i achieve something like that?

captussre

What I need is just to have a single line with circles at each point.

Like the one from http://andreaferretti.github.io/paths-js-react-demo/

captasasdcure

ibrahimahmed-io avatar Jan 10 '17 01:01 ibrahimahmed-io

Circles on the points isn't something doable with the current codebase as it exists but it's certainly a reasonable feature request. You're welcome to try and implement it yourself and submit a PR. Otherwise, I'll keep this one open for someone else or me to implement.

marzolfb avatar Jan 12 '17 02:01 marzolfb

@IbrahimAmin i have the same question, are you achieve that?

qiangspecial avatar Feb 20 '17 07:02 qiangspecial

I was expecting to achieve this functionality for a certain long time also. i.e. the option to be able to display the data points on the chart.

I also understand; this option would also help addressing issue #83 but a much better option would be to implement a 'monotone cubic interpolation' method instead of the basic bezier function in 'bezier.js' that would eliminate the 'overshooting' issue definitely.

I have run across many other libs that utilizes this functionality and those smoothline charts really shine in this aspect. a good example is d3.js charts; https://bl.ocks.org/mbostock/4342190 displays this problem beautifully; check 'basis' and 'monotone' options to see it)

another example with code is; http://blog.mackerron.com/2011/01/01/javascript-cubic-splines/

Otherwise basic bezier splines are always troublesome regarding 'overshooting' and 'displaying of nonexistent values' which practically renders smoothline charts useless practically.

I wish we could implement this functionality here. Actually its only another spline calc function instead of the standard bezier function against the data points and could be implemented easily. I wish I could contribute but I dont quite get the hang of the code flow here in react-native-pathjs-charts.

WeaVaer avatar Jul 28 '17 08:07 WeaVaer

@Ibrahim-GHub have you had any success with pathjs or any other react native component? Would really like archieve the same chart.

Softrabbit-de avatar Oct 05 '17 06:10 Softrabbit-de

@Softrabbit-de I used this one in the end https://github.com/PhilJay/MPAndroidChart

ibrahimahmed-io avatar Oct 19 '17 09:10 ibrahimahmed-io

@Ibrahim-GHub thanks for your hint. I switched to Victory last week :)

Softrabbit-de avatar Oct 20 '17 08:10 Softrabbit-de