react-native-pathjs-charts icon indicating copy to clipboard operation
react-native-pathjs-charts copied to clipboard

Published 20 hours ago • verified publisher icon capitalone

pallete prop is misspelled

Open tuantle opened this issue 7 years ago • 1 comments

Please rename to palette.

tuantle avatar Jul 26 '17 07:07 tuantle

Agreed this is a bug. Just for historical context, this library is based off of https://github.com/rsamec/react-pathjs-chart and that seems to be where the misspelling originated.

While introducing a new property with the correct spelling is straightforward and non-controversial, removing the old misspelled version of the property is arguable as doing so would be introducing a breaking change. It would be interesting to hear from others on whether a breaking change like that would be appropriate.

marzolfb avatar Jul 30 '17 05:07 marzolfb