fpe

fpe copied to clipboard

Arbitrary alphabet support

10

## What's in this PR? This PR extends the radix range supported by the FF1 and FF3 packages from 62 to 65536. It also adds support for alphabets containing utf-8...

martinwaite

## Description of Issue In the FF3 constructor. The 3rd check in the ‘if’ statement looks redundant. It seems to test if maxLen > maxLen, which must always be false?...

bschoening

maxLen is incorrectly being calculated by moving the multiplication by 2 into the floor, whereas the spec calls for the multiplication to happen outside (after) the flooring. This causes the...

anitgandhi

https://github.com/capitalone/fpe/blob/e6bfa0dae121111c2e93483777f0f2cde562f341/ff3/ff3.go#L374-L377

anitgandhi

Welcome to [WhiteSource Bolt for GitHub](https://github.com/marketplace/whitesource-bolt)! This is an onboarding PR to help you understand and configure settings before WhiteSource starts scanning your repository for security vulnerabilities. :vertical_traffic_light: WhiteSource Bolt...

mend-bolt-for-github[bot]

FF3-1

2

Is there a plan to update the FF3 code to FF3-1? Thanks!

bdw617

Unused `R` in decryption

5

Looking here: https://github.com/capitalone/fpe/blob/e6bfa0dae121111c2e93483777f0f2cde562f341/ff1/ff1.go#L484 The comment suggests `R` should be used but it is entirely unused. (As [reported by staticcheck here](https://console.muse.dev/result/TomMD/fpe/01EMPV1FFX1FVTWG0Q2A43DAA7)). Is this dead/delete-able or does it indicate a decryption error?

TomMD

Please add trusted reviewers to your code owners file and write team if necessary. Thanks!

tmbjmu

fixed typo

1

## What's in this PR? Please provide a description of what is contained in this Pull Request. ## TODOs If there are some outstanding items you would like to complete...

phannam1412

## What's in this PR? Creating CODEOWNERS file for project owner to identify appropriate PR reviewers.

tmbjmu