SWHttpTrafficRecorder icon indicating copy to clipboard operation
SWHttpTrafficRecorder copied to clipboard

Respose headers not saved when using Mocktail format

Open wangyun opened this issue 9 years ago • 9 comments

Respose headers not saved when using Mocktail format

wangyun avatar Mar 28 '16 17:03 wangyun

We do not want to save every response header to reduce the size. Do you have a need to save a particular header for your app? Do you have any thoughts over how to do it, maybe a pull request once figured it out?

JinlianWang avatar Mar 28 '16 18:03 JinlianWang

For debug and test purpose, does size matter? and absence of headers make the record useless. I think it's easy to add headers, like in SWHTTPTrafficRecordingFormatHTTPMessage format.

wangyun avatar Mar 29 '16 06:03 wangyun

You convinced me:-] If you have a ready to check in code (and make sure that it can be consumed by Mocktail lib or OHHTTPStatus), feel free to submit a pull request. Otherwise I will dig the code to record header and put it in.

JinlianWang avatar Mar 29 '16 15:03 JinlianWang

I just found this issue so I haven't any code for this, but I will fork and try to add header info, If I can make it work with OHHTTPStubs, I will make a PR.

wangyun avatar Mar 30 '16 08:03 wangyun

@JustinMollenauer This is the issue we talked about. If you can pull in your code here, that would be really great help. Thanks!

JinlianWang avatar Jul 22 '16 12:07 JinlianWang

@JinlianWang I submitted PR #9 with the code for adding headers.

JustinMollenauer avatar Jul 22 '16 13:07 JustinMollenauer

@wangyun The headers are recorded now. If you have a chance to verify and close the issue, that would be great.

JinlianWang avatar Aug 21 '16 21:08 JinlianWang

@JustinMollenauer Can you please confirm that PR #9 solves the issue, so that we can close this issue?

jaredsmith avatar Nov 01 '16 19:11 jaredsmith

@jaredsmith Can confirm, PR #9 fixed this issue.

JustinMollenauer avatar Nov 02 '16 14:11 JustinMollenauer