Particle-Cloud-Framework icon indicating copy to clipboard operation
Particle-Cloud-Framework copied to clipboard

aws - batch job and batch job definition [draft PR]

Open faizanfahmed opened this issue 6 years ago • 6 comments

Looking for feedback on batch job particle and batch job definition particle. Need to add testing, potentially introduce error handling or retry logic, and improve sync_state/update functions. Unsure on how to handle is_state_equivalent function.

faizanfahmed avatar May 20 '19 17:05 faizanfahmed

@faizanfahmed thanks for pr! If you haven't already I would recommend creating an example file so that you could try out creating and terminating your particle. It will help us review as well. We have all aws examples in this folder https://github.com/capitalone/Particle-Cloud-Framework/blob/master/examples/particle/aws/ if you want to take a look

davidyum avatar May 20 '19 17:05 davidyum

I'll definitely add an example and start running through the lifecycle. Thanks!

faizanfahmed avatar May 20 '19 17:05 faizanfahmed

#80

anovis avatar May 23 '19 16:05 anovis

Definitely need to add unit test as well. Looks like Moto does support Batch. But I'm not sure how complete it is. https://github.com/spulec/moto/tree/7f0b1d679591a6b69f5d620b2b0ff0a311ed7582/moto/batch

Otherwise, we use Placebo as well. @anovis added a tool to help making generating Placebo test. https://github.com/capitalone/Particle-Cloud-Framework/pull/114

ethanwlo avatar May 23 '19 20:05 ethanwlo

looks like small merge conflict. once you fix it looks ready to merge. thanks for pr!

anovis avatar Jun 24 '19 16:06 anovis

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Faizan Ahmed seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 21 '20 01:07 CLAassistant