DataProfiler
DataProfiler copied to clipboard
Static Type Hinting: `dataprofiler/data_readers/`
Is your feature request related to a problem? Please describe. Improve the project in the area of
- Make collaboration and code contribution easier
- Getting started with the code when a contributor is new to the code base
Describe the outcome you'd like:
Utilizing types from mypy documentation for python3, implement type hinting in the dataprofiler/data_readers/
folder. In this case, because there are multiple files in the folder, at the very minimum the changes should be partitioned out into multiple Pull Requests (PRs). Potentially this could go so far as 1 PR --> 1 file update with type hints.
Additional context:
- mypy documentation
- Why use python types?
Because this folder is so large, I recommend making more PRs that are smaller (3 - 4 files at a time / keep the net diff number lower when possible).
@Sanketh7 just these last three PRs and this will be complete? Is that right?
@Sanketh7 just these last three PRs and this will be complete? Is that right?
There are 2 more files that need static typing but these are very short and I'll have a PR for them up soon.
All merged. Closing. Thanks @Sanketh7