DataProfiler icon indicating copy to clipboard operation
DataProfiler copied to clipboard

Static Type Hinting: `dataprofiler/labelers/`

Open taylorfturner opened this issue 3 years ago • 1 comments
trafficstars

Is your feature request related to a problem? Please describe. Improve the project in the area of

  • Make collaboration and code contribution easier
  • Getting started with the code when a contributor is new to the code base

Describe the outcome you'd like: Utilizing types from mypy documentation for python3, implement type hinting in the dataprofiler/labelers/ folder. In this case, because there are multiple files in the folder, at the very minimum the changes should be partitioned out into multiple Pull Requests (PRs). Potentially this could go so far as 1 PR --> 1 file update with type hints.

Additional context:

taylorfturner avatar Aug 12 '22 03:08 taylorfturner

Because this folder is so large, I recommend making more PRs that are smaller (3 - 4 files at a time / keep the net diff number lower when possible).

taylorfturner avatar Sep 15 '22 13:09 taylorfturner

@tonywu315 just this last PR and this will be complete? Is that right?

taylorfturner avatar Oct 06 '22 18:10 taylorfturner

yep

tonywu315 avatar Oct 07 '22 04:10 tonywu315

Closing since all are merged 🥳 CC @JGSweets

taylorfturner avatar Oct 07 '22 15:10 taylorfturner