DataProfiler icon indicating copy to clipboard operation
DataProfiler copied to clipboard

Static Type Hinting: `dataprofiler/reports/graphs.py`

Open taylorfturner opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Improve the project in the area of

  • Make collaboration and code contribution easier
  • Getting started with the code when a contributor is new to the code base

Describe the outcome you'd like: Utilizing types from mypy documentation for python3, implement type hinting in dataprofiler/reports/graphs.py.

Additional context:

taylorfturner avatar Aug 12 '22 03:08 taylorfturner

I'm working on this.

stefanycoimbra avatar Sep 17 '22 22:09 stefanycoimbra

Sounds great -- we will keep an eye out for the PR, @stefanycoimbra

taylorfturner avatar Sep 18 '22 01:09 taylorfturner

Hey @stefanycoimbra! Any update on this? Thanks!

taylorfturner avatar Sep 26 '22 14:09 taylorfturner

Yes, I'm trying to submit it now. Sorry for the delay, I had to fix my computer.

stefanycoimbra avatar Oct 06 '22 21:10 stefanycoimbra

Sounds good! I'll take a look tomorrow - thanks for the contribution!

taylorfturner avatar Oct 06 '22 22:10 taylorfturner

PR merged! Thanks again, @stefanycoimbra !

taylorfturner avatar Oct 17 '22 19:10 taylorfturner