DataProfiler icon indicating copy to clipboard operation
DataProfiler copied to clipboard

Possible Optimization Bugs Since There Are No Tests

Open grant-eden opened this issue 4 years ago • 1 comments

General Information: The repo has been optimized to reduce the amount of shuffles and add multiprocessing. Both have been merged into the repo without any tests.

There needs to be tests to ensure the repo is shuffling properly when it is maintaining the shuffle indices and when it is not. The new utils function for shuffling needs to be tested.

In multiprocessing, there are no tests to make sure any of the multithreading is working appropriately. Most importantly, single threading needs to be tested to make sure that option still works.

grant-eden avatar Apr 05 '21 16:04 grant-eden

There actually is an issue that if an error is caused in MP due to a change, we currently have no test to catch it. We need to add a test to address.

JGSweets avatar Sep 01 '21 13:09 JGSweets