DataProfiler
DataProfiler copied to clipboard
capitalone
feat: add __str__ methods to the various part of the profiler options
How about this as a starting point for adding some helpful printing of Data Profiler options?
import dataprofiler as dp
profile_options = dp.ProfilerOptions()
print(profile_options)
You'll want to rebase onto dev... had some other PRs from @gliptak merge into dev this morning.
Have you done rebases before, @carlsonp?
Thanks, I'll get to it next week. Fighting off a bug.
On Fri, Mar 22, 2024, 2:51 PM Taylor Turner @.***> wrote:
@carlsonp https://github.com/carlsonp you should be good to rebase onto dev now
— Reply to this email directly, view it on GitHub https://github.com/capitalone/DataProfiler/pull/1115#issuecomment-2015803205, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5DNM6YUBHLUBLCTAKNNDYZSDTNAVCNFSM6AAAAABEU57M7GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJVHAYDGMRQGU . You are receiving this because you were mentioned.Message ID: @.***>
@carlsonp yeah, I like the route you are going. Once you add unit tests, just tag me and I'll take another look at it. Cheers!
@carlsonp yeah, I like the route you are going. Once you add unit tests, just tag me and I'll take another look at it. Cheers!
@taylorfturner Can you please provide a suggested starting point for which file to add the unit tests?
@carlsonp yeah, I like the route you are going. Once you add unit tests, just tag me and I'll take another look at it. Cheers!
@taylorfturner Can you please provide a suggested starting point for which file to add the unit tests?
Yes, indeed! I would actually move some of the __str__ methods you overwrite in this PR into base_options.py. Then I think your testing would much more simple. Ultimately this would allow you to test main implementation in test_base_option.py then you could build out small scenarios in the other option test files in tests/profilers/profiler_options/...