rvm
rvm copied to clipboard
capistrano
rvm_map_bins should contain rails
The rails command should be included in the rvm_map_bins as it is in the capistrano-rbenv gem
+1, IMO it makes sense for the rvm extension to match the rbenv one in this regard.
Not sure about this. capistrano-rvm is trying to be framework agnostic. Should be include sinatra or padrino binaries as well?
Good point. But if capistrano-rvm does not include rails then capistrano-rails has to add itself to rvm_map_bins.
So, it's the same question: Should capistrano-rails be agnostic to Ruby version management tools?
In my opinion it is easier to add it to the capistrano-rvm instead to capistrano-rails.
Btw: sinatra has no binary.
+1 on including rails in rvm_map_bins.
Not having it there can lead to failures when running remote cap tasks that are hard to figure out & can take a lot of time (e.g. you think "OMG it's something else I've messed up in how my VPS is setup ... let me go dig into what what env is in place when this remote task is run, what PATH's are set, etc, etc")
Please merge this PR. I can confirm rails command should be included in an array map so that some capistrano plugins could work correctly.
@stevenchanin Agreed - but is the real solution to have better errors? For me, this was just saying "no output" when it should have said "rails: command not found" which would have made this an easy fix.
