rbenv icon indicating copy to clipboard operation
rbenv copied to clipboard

Update README.md

Open hbin opened this issue 10 years ago • 4 comments

This line is misleading. It will override the rbenv_map_bins, and will lead to some unexpected issue to others packages.

https://github.com/seuros/capistrano-sidekiq/issues/124

hbin avatar Nov 20 '15 11:11 hbin

This is how you actually use this gem. Without that line these commands would not be executed through rbenv.

amw avatar Dec 20 '15 15:12 amw

@amw These was set by default

hbin avatar Dec 21 '15 00:12 hbin

Yes, I know, but do you mean that if you remove that line from your deploy config it will help with compatibility with other plugins? It would be a design problem of these other plugins then.

It is an option that rbenv exposes and users are allowed to add additional commands to that list. This line in README just explicitly sets the var to it's default value which is a nice and standard way to present the options to users.

amw avatar Dec 21 '15 09:12 amw

This is certainly an issue, although I don't think removing it from the readme is the right solution…

The deeper issue is that we are recommending that the end user set this when really, they shouldn't unless they need to.

Here's a different approach: https://github.com/capistrano/rbenv/pull/76

will-in-wi avatar Oct 13 '17 12:10 will-in-wi