Wyatt Gillette
Wyatt Gillette
> You could still leave this open for the other parts that are okay (like the formatting, imports and copyright) if you'd like to still update things and submit those...
Personally, I do not think this is an acceptable solution. This class is not necessary for the proper functioning of the engine. It is a utility class and should be...
Alternatively, I propose moving this class to the `jme3-examples` module, where it can serve as a basis for users who wish to optimize or adapt it for their projects.
> Not moving to examples, certainly, but moving to `jme3-plugins` might be a good idea. I strongly disagree. Including it in the core module was a mistake, and moving it...
This is the last PR I would like to propose, but as mentioned before, it requires the merge of the other PR.
Just a few suggestions: 1. **Restore Unrelated Files:** Please remove any files that haven't been modified as part of this specific change. (eg: _com.jme3.anim.tween.Action_, _com.jme3.post.filters.DepthOfFieldFilter_, etc...) 2. **Revert Formatting Changes:**...
Other than the latest revision, I don’t have any additional technical changes to propose. I currently lack sufficient information to determine whether your API is flexible enough for future developments....
While I'm not a big fan of this monolithic approach, as similar solutions tend to be complex to maintain and evolve over time, I agree with the idea of creating...
Fix javadoc + Restore variable names: * `capsule` for `OutputCapsule` * `ic` for `InputCapsule`
Regarding the proposal to directly expose fields in `Quaternion` and `Matrix3f`, I believe this is a **fundamental step** toward optimizing crucial aspects of our engine and aligning with an already...