capacitor-plugins icon indicating copy to clipboard operation
capacitor-plugins copied to clipboard

feat(android-foreground-service): add ability to define notification channel options

Open DoctorMcKay opened this issue 1 year ago • 1 comments

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [x] The changes have been tested successfully.
  • [x] A changeset has been created (npm run changeset).
  • [x] I have read and followed the pull request guidelines.

Close #266

Adds a new createNotificationChannel method which allows implementing apps to create a notification channel prior to starting a foreground service. If a channel is not explicitly created, it's created with the same default values as previously when startForegroundService is called.

DoctorMcKay avatar Aug 21 '24 05:08 DoctorMcKay

Thank you for creating this PR! Please just copy the implementation from the Capacitor Firebase Messaging plugin, see https://github.com/capawesome-team/capacitor-firebase/blob/42d77fecca3871b910ac809bf1d14ff0c60dd762/packages/messaging/src/definitions.ts#L117

You can keep the method name createNotificationChannel. You would also need a deleteNotificationChannel method.

robingenz avatar Aug 21 '24 08:08 robingenz

It looks like there hasn't been a reply in 30 days, so I'm closing this issue.

github-actions[bot] avatar Oct 14 '24 08:10 github-actions[bot]