Jiri Spac

Results 238 comments of Jiri Spac

I tried to rephrase the title. Was that what you meant?

are you using typescript? For me it is saying this ![image](https://github.com/user-attachments/assets/cf99389c-da62-47b2-b733-fcb821ad98d3) I have the `binance 2.12.2`

I am using bun, this is my tsconfig ``` { "compilerOptions": { "module": "ESNext", "esModuleInterop": true, "target": "ESNext", "moduleResolution": "Bundler", "forceConsistentCasingInFileNames": true, "noFallthroughCasesInSwitch": true, "isolatedModules": false, "strict": true, "noImplicitAny": true,...

ah sorry I opened #153 didn't find this one. Should I close it @orta ?

Just tried it in Bun and it works gr8, looks good to me on my chart here: ![chart](https://github.com/user-attachments/assets/bbab228b-a805-455e-a561-c32ac4fe1a1b)

@kibertoad agree with you, being able to set this on parse method would be nice, but I'd make it opt-out, not opt-in

envbool sounds like the usage is limited to env vars, which is not the case. Please rename the proposed method to stringBool or `stringAsBool()`

@kamilkisiela maybe I am missing some context, but I wanted to ask: Are you planning to implement these unchecked ones here in this PR? ![image](https://github.com/kamilkisiela/graphql-hive/assets/1305378/79f464a5-3108-4182-9403-7c1521c8898c) Could we merge this as...

will compile a brief proposal for this. Mostly it will be about listing all important CRUD actions that happen inside these managers ![image](https://github.com/kamilkisiela/graphql-hive/assets/1305378/51464a22-5ef6-4285-9c80-dc7666f55e5b) and manually inserting into a single clickhouse...

I wrote a brief proposal here: https://github.com/kamilkisiela/graphql-hive/blob/audit-log-wip/docs/proposals/proposal-audit-log.md I even opened it here for a draft PR in case you would want to comment on specific lines in the markdown doc:...