safe-area icon indicating copy to clipboard operation
safe-area copied to clipboard

Fix IME paddings

Open JanPolasek opened this issue 1 year ago • 2 comments

This reverts commit acfaa0cda35792e10fd1a67e711af582d633261f and fixes #38.

Overall this PR has 2 separate parts:

  1. Revert of acfaa0cda35792e10fd1a67e711af582d633261f. The Stackoverflow thread mentioned in the original code does provide what it says on the tin - a way to get the height of just the keyboard, but in the case of this plugin that isn't the desired value, the bottom inset needs to be both the keyboard height and the navbar height together, otherwise content will be partially underneath the keyboard.
  2. A change of which View the IME padding is applied to. If applied to the decor view it pushes any existing navigation bar background above the keyboard (and over the app's content).

I've tested this on several devices and android versions (11, 14, 15, though of course all on targetSdk 34), but only one app. So if there's anyone for whom alpha.8 worked correctly, there's gotta be something else in how our respective apps are configured, but I really can't think of anything that could do that.

JanPolasek avatar Jan 13 '25 20:01 JanPolasek

lgtm, pls merge and release

danielehrhardt avatar Jan 27 '25 17:01 danielehrhardt

@tafelnl We need your review.

seravifer avatar Feb 07 '25 16:02 seravifer

please....

SvenBudak avatar Jul 10 '25 20:07 SvenBudak

We need this fix or move the inclusion of this functionality under a flag in the configuration...

gewisser avatar Aug 13 '25 11:08 gewisser

This plugin has been sunset. See the readme for more info

tafelnl avatar Sep 23 '25 15:09 tafelnl

Good news. I've unsunsetted this plugin. More about that here: https://github.com/ionic-team/capacitor/issues/8121#issuecomment-3512232632

tafelnl avatar Nov 10 '25 15:11 tafelnl