intercom icon indicating copy to clipboard operation
intercom copied to clipboard

bring back firebase, fix android push notifications

Open jpike88 opened this issue 10 months ago • 5 comments

fixes #87

jpike88 avatar Feb 13 '25 13:02 jpike88

These changes look good to me. Unfortunately, I'm unable to test Android.

Are you cool with these @jcesarmobile ?

stewones avatar Apr 16 '25 13:04 stewones

@jcesarmobile do you plan to look at this at some point?

jpike88 avatar Jun 09 '25 05:06 jpike88

The plugin never had firebase notifications implemented, it had a dependency to firebase messaging, but no code. I removed the dependency because it was causing issues since it was using a fixed version. The docs mention @capacitor/push-notifications should be used, if this gets merged then it will interfere with @capacitor/push-notifications push message handling, so probably shouldn't be used anymore and should in fact recommend not using it as it would cause issues. But then what about iOS? this PR only implements Android.

Anyway, I don't have experience with intercom, so it's up to you what you merge and what not.

jcesarmobile avatar Jun 20 '25 13:06 jcesarmobile

@jpike88

why you can't use @capacitor/push-notifications ?

jcesar is right, we should not pin firebase messaging dependencies here.

stewones avatar Jun 20 '25 19:06 stewones

I do use @capacitor/push-notifications, that's the problem. It somehow overrides or cancels out the intercom's plugin push receiving functionality for contacting our customers.

https://github.com/capacitor-community/intercom/issues/87#issuecomment-2548764919

I didn't just make this PR for fun, I made it because this repo does not work. My fix makes it work.

Up to you guys but I have no reason to move back to main repo when it's literally broken for me.

jpike88 avatar Jun 21 '25 04:06 jpike88