firebase-analytics setUserId accept null too #49

setUserId accept null too #49

Open markxoe opened this issue 4 years ago • 6 comments

I've solved #49 so that null will be accepted by setUserId and in the web-version it gets converted to an empty string

Feb 16 '21 11:02 markxoe

Any update on this PR? I am also waiting on this fix

Aug 17 '21 20:08 MNorgren

I have some time set aside later this week for this.

Aug 17 '21 21:08 brownoxford

Hi, I also need to unset the userId via setUserId. @brownoxford do you think you need help to merge this PR?

Nov 23 '21 15:11 edouardruiz

@brownoxford @edouardruiz any updates?

May 18 '22 07:05 sergeivoroshilov

Also interested by this. Any news @brownoxford?

May 23 '22 10:05 sneko

@markxoe it seems your PR is not fixing the issue unfortunately. For example on iOS:

https://github.com/capacitor-community/firebase-analytics/blob/962a66634da4a575b8e3bfb45f5fd7e66c36ecec/ios/Plugin/Plugin.swift#L25-L29

Since it expects a "string" it will raise an error in all cases. Did you test your implementation? (maybe I'm doing something wrong)

May 23 '22 15:05 sneko