bluetooth-le
bluetooth-le copied to clipboard
feat: improve iOS detected devices view
This avoid overlapping / improved iOS device view.
Before this PR:
After:
Thanks for taking the time to raise this!
Interesting bug you've encountered here! I wish there was an easier way to workaround this...
The new interface you've added here looks ok, but it has a lot of visual and behaviour differences compared to the version it replaces.
Main things that stick out to me are:
- The colours, fonts, layout and button shape are all very different from the original dialog
- This dialog has a fixed height that takes up the majority of the screen, making it far less attractive if there are only one or two devices in the scan that are applicable
Would you have the time to try and align it a little more closely with the UIAlertController it replaces?
Ok, I've tried to make it feel more like a dialog for devices. (mind that as you see also in the current alert the Scanning... is very small).
Anyway, more blurry like iOS and on iOS 15+ I can easily make the view take less space. For iPad and macOS that was never an issue as it shows as a modal in the center.
Hope this is closer to what you had in mind.
Sorry for bumping this, but I'd like to use the main branch for another project which I want to PR and this really improves experience on iOS.
Thank you again.
I shall endeavour to look at this soon @talaviram
Apologies, time slipped away from me on this.
I've merged this @talaviram !
Thanks so much for the contribution. I've made one change, which is to put this behind an opt-in flag when calling requestDevice. The reason is that I don't want to force a UI change of people during a minor rev bump.
For the 8.x series, I'll consider swapping this over by default.
@all-contributors please add @talaviram for code