app-icon icon indicating copy to clipboard operation
app-icon copied to clipboard

Android support

Open alexcroox opened this issue 4 years ago • 14 comments

Describe the solution you'd like Android support

Describe alternatives you've considered A reference lib that may or may not help https://github.com/myinnos/AppIconNameChanger

Many thanks

alexcroox avatar Mar 22 '21 13:03 alexcroox

is there any progress on this?

hasanaktas avatar Dec 27 '21 04:12 hasanaktas

any idea when this plugin will support android?

izeryab avatar Mar 21 '22 10:03 izeryab

I am working on a solution. Stay tuned.

johnborges avatar Apr 15 '22 00:04 johnborges

@johnborges can I support you somehow? would love to have that feature 🙏

chvonrohr avatar Jul 04 '22 13:07 chvonrohr

@johnborges any progress making this work on Android as well, seems to have good support for changing the app icon similar to iOS.

WillooWisp avatar Jul 15 '22 08:07 WillooWisp

Would love to have that feature

koentjuh1 avatar Aug 29 '22 11:08 koentjuh1

@johnborges any timeframe you can share?

WillooWisp avatar Sep 07 '22 12:09 WillooWisp

I have something partially working that I will share shortly. I'll likely publish a beta version for everyone to test and give feedback on.

johnborges avatar Sep 08 '22 13:09 johnborges

@johnborges that would be great. I'd be happy to test the beta. thanks 👏

chvonrohr avatar Sep 09 '22 07:09 chvonrohr

@johnborges sounds great!

WillooWisp avatar Sep 14 '22 06:09 WillooWisp

3.1.0-beta.0 has been published with Android support.

The only method currently supported is change(). You also need to specify the icons that need to be disabled as an additional option. The android project in example is a good place to look for references.

johnborges avatar Oct 03 '22 01:10 johnborges

@johnborges

Nice to see the beta even on NPM, many thanks 👏

I implemented the plugin and tested on various Android devices. Easy and straightforward with the example you added 👍

I had the following issues though:

  • Android < 10: when minimising app after icon change, it takes a while until previous icon is removed and new appears. Clicking on the icon errors in "not installed". It works again once the new icon appears.
  • Android < 10: having the app somewhere placed in the folders removes the icon from there. Only accessible from the all-apps list.
  • not working on ARM simulator right?
  • Android > 10: As I also experienced in my prototype from the pull request, there is an issue that the app is closed when change is executed. Same issue was discussed in the react native forum and on Stackoverflow -> or maybe something wrong in my AndroidManifest.xml (see androidmanifest-part.log for the activity part)?

Test device (real devices):

  • Android 7 (LG G6): ALL GOOD
  • Android 8.1 (HTC_U12_life): ALL GOOD
  • Android 9 (Honor Play): ALL GOOD
  • Android 9 (Samsung Galaxy A9): ALL GOOD
  • Android 10 (Samsung Galaxy A10) - APP CLOSES!
  • Android 11 (Google Pixel 4a) - APP CLOSES!
  • Android 12 (Google Pixel 4) - APP CLOSES!
  • Android 12.1 (Google Pixel 6) - APP CLOSES!
  • Android 13 (Google Pixel 4) - APP CLOSES!

chvonrohr avatar Oct 04 '22 21:10 chvonrohr

@chvonrohr Thanks for testing! I'll create some additional avds with the platform versions and devices you mentioned. Lets see if I can get anything in the logs. I only used Android 13 on a Pixel 5 emulator when first working on this.

johnborges avatar Oct 05 '22 18:10 johnborges

@johnborges Nice to see Android support as well.

Two things...

  1. Any solution to the app getting closed upon change of app icon?
  2. Will reset app icon feature be possible, or not support by Android?
  3. Will get current app icon name function be implemented on Android?

WillooWisp avatar Nov 17 '22 08:11 WillooWisp