admob icon indicating copy to clipboard operation
admob copied to clipboard

should I add com.google.android.gms.permission.AD_ID as the permission or it's getting merged into androidmanifest.xml

Open mhamri opened this issue 3 years ago • 3 comments

Is your feature request related to a problem? Please describe.

recently I received a declaration form for my app image

this require that the app has <uses-permission android:name="com.google.android.gms.permission.AD_ID"/> as one of the permission.

I was going through documentations and noted that it should be added by default

Some SDKs, such as the Google Mobile Ads SDK (play-services-ads) may already declare this permission in the SDK’s library manifest. If your app uses these SDKs as dependencies, the AD_ID permission from the SDK’s library manifest will be merged with your app’s main manifest by default, even if you don’t explicitly declare the permission in your app’s main manifest. Learn more about merging manifest files on the Android Developers site.

I went and looked at the build/outputs/logs/manifest-merger-release-report.txt and didn't see anyting related to AD_ID in the merged manifest file.

so I have two questions,

  • should I go ahead and add this permission into the manifest? do I need to change any code related to that? shouldn't it be added automatically to the manifest (according to the document as we are using Google Mobile ads SDK)?

Describe the solution you'd like

  • updated documentation
  • probably add this permission automatically

Describe alternatives you've considered not sure

Additional context https://support.google.com/googleplay/android-developer/answer/12253906#flag_secure_preview

mhamri avatar Jul 29 '22 16:07 mhamri

@mhamri How did you resolve this?

musukwamoshi avatar Nov 18 '22 14:11 musukwamoshi

@musukwamoshi I added the permission manually for the time being, but I believe the plugin should take care of that

mhamri avatar Nov 19 '22 16:11 mhamri

Google is showing me the same message in this case if it should be added manually or does the plugin already do it?

I was looking at android\app\build\outputs\logs\manifest-merger-release-report.txt and I found a related log on AD_ID does that mean it is used?

ADDED from [com.google.android.gms:play-services-base:18.0.1] C:\Users\HABI\.gradle\caches\transforms-3\8ff1e9f283fdec7034b38b65639640bb\transformed\jetified-play-services-base-18.0 .1\AndroidManifest.xml:20:19-85
uses-permission#com.google.android.gms.permission.AD_ID

willydavid1 avatar Apr 06 '23 00:04 willydavid1