[BUG] Error "... has no exported member ..." in generated code

[mcastrup]

Is there an existing issue for this?

• [X] I have searched the existing issues

Nature of Your Project

TypeScript

Current Behavior

In one of the generated files, there are two errors regarding the import and usage of "Currencies":

Error message: '"c:/Users/D048091/git/crypto-for-business/@cds-models/sap/common/index"' has no exported member named 'Currencies'. Did you mean 'Currency'?

The code can be also seen in this file:

export function _FiatCurrencyAspect<TBase extends new (...args: any[]) => object>(Base: TBase) {
  return class FiatCurrency extends Base {
        name?: string | null;
        descr?: string | null;
        code?: string;
        symbol?: string | null;
        minorUnit?: number | null;
        texts?: __.Composition.of.many<_sap_common.Currencies.texts>;
        localized?: __.Association.to<_sap_common.Currencies.text> | null;
    /**
    * Type for a language code
    */
        localized_locale?: _sap_common.Locale | null;
        localized_code?: string | null;
      static actions: {
    }
  };
}

The related entity to the FiatCurrency class is:

using {sap.common.Currencies} from '@sap/cds-common-content';

namespace sap.erp4sme.c4b.payment.fiatCurrencies;

@cds.persistence.skip: false
entity FiatCurrencies as select from Currencies;

See also this file.

Expected Behavior

I'm not sure what is the correct code. Of course, there should be no errors.

Steps To Reproduce

You can clone our repository crypto-for-business locally with git clone https://github.tools.sap/erp4sme/crypto-for-business.git, checkout the branch switch_to_typer_prototype and run npm ci and npm run cds-typer:dev

Environment

- **OS**: Windows
- **Node**: v18.13.0
- **npm**: 8.19.3
- **cds-typer**: 0.15.0
- **cds**: 7.4.1

Repository Containing a Minimal Reproducible Example

No response

Anything else?

No response

[hakimio]

Is the issue fixed if you import sap.common.Currencies from @sap/cds/common instead of @sap/cds-common-content? The definition will be the same.

[mcastrup]

Hi @hakimio I changed the import as you suggested to using {sap.common.Currencies} from '@sap/cds/common'; However, the error still exists.

[daogrady]

Hi Michael,

this issue is actually closely related to https://github.com/cap-js/cds-typer/issues/77

Localisation and text properties are not supported by cds-typer at this point in time. So it is to be expected that their type is incorrect. I am more suprised that cds-typer attempts to generate them regardless, as we are currently skipping them. I will look into it.

Best, Daniel

[mcastrup]

Hi Daniel,

do you have an idea, when this issue will be fixed? It currently blockes our build process.

Thanks and best regards, Michael

[daogrady]

Hi Michael,

sorry, I am afraid not any time soon from my side, as I have to prioritise another project for an upcoming release. If you would like to submit a PR to address the problem, I will make sure to carve out some time to review it to make sure the issue is fixed asap.

Best Daniel

[github-actions[bot]]

This issue has not been updated in a while. If it is still relevant, please comment on it to keep it open. The issue will be closed soon if it remains inactive.

[daogrady]

Hi Michael,

I just re-checked your issue and this is addressed as of 0.32.1. I am therefore closing this as fixed, but feel free to reopen if it should resurface.

Best, Daniel