forms icon indicating copy to clipboard operation
forms copied to clipboard

Don't type cast non-sensible values

Open voxpelli opened this issue 4 years ago • 3 comments
trafficstars

Fixes #186 by checking if it's a sensible value before it casts it, so that non-sensible values won't be casted to eg. a string

voxpelli avatar Jan 19 '21 23:01 voxpelli

Not really sure how to fix this? Skärmavbild 2021-01-20 kl  01 01 32 Skärmavbild 2021-01-20 kl  01 02 34

voxpelli avatar Jan 20 '21 00:01 voxpelli

I'll take a look, but I don't think you have to worry about that one.

ljharb avatar Jan 20 '21 00:01 ljharb

I'd need to see some test cases that cover this new behavior.

What is a "non-sensible" value? As I mentioned in #186, values sent over the wire are only ever strings, so it's a bit strange to allow a non-serializable value.

ljharb avatar Jan 20 '21 04:01 ljharb