Make create return an instance with prototype

[JoeChapman]

I want to override the handle function returned when create is called. However, I cannot do so because there is not way to get at the definition. How would you feel about a PR that made create return an instance with handle on the prototype?

[ljharb]

Can you explain more of your use case? I'm pretty strongly biased against "new" and would prefer to avoid that approach, but maybe we can find another way to achieve what you need.

[JoeChapman]

Hi, I would like to be able to override the handle function in order to write a default set of rules for handling errors and success so I don't have to write the same patterns each time.

I can rewrite handle, but only on the form I have created, not on all forms I create from the form 'class'. If form.create returned an instance of a 'class', with 'handle' a prototype of that class, I could partially override the definition of handle.

You would not need to expose the uninstantiated constructor to the consumer of the interface, create could return a new instance.

[ljharb]

could you write a function like:

var formCreate = function () {
  var form = forms.create.apply(forms, arguments);
  form.handle = myHandle;
  return form;
};

[JoeChapman]

would that allow me to call the original handle function from within myHandle?

[ljharb]

Sure, you could do:

var formCreate = function () {
  var form = forms.create.apply(forms, arguments);
  var origHandle = form.handle;
  form.handle = function () {
    myHandle.call(this, arguments);
    return origHandle.call(this, arguments);
  };
  return form;
};

[JoeChapman]

However, it becomes a little awkward when I start separating code into modules because I want to export forms with a new definition of create, not a form object, as above.

[ljharb]

You could make a new module joe-forms that takes forms, saves a reference to the original create function, makes a formCreate like the example above and sticks that on .create, and then use joe-forms instead of forms.