advisingapp icon indicating copy to clipboard operation
advisingapp copied to clipboard

[ADVAPP-1404]: Email formatting does not appear consistently across messages and email views

Open ankit-canyon opened this issue 8 months ago • 4 comments

Ticket(s) or GitHub Issue

  • https://canyongbs.atlassian.net/browse/ADVAPP-1404

Technical Description

Fixed: Email formatting does not appear consistently across messages and email views.

Any deployment steps required?

No.

Are any Feature Flags and/or Data Migrations that can eventually be removed Added?

No.


Before contributing and submitting this PR, make sure you have Read, agree, and are compliant with the contributing guidelines.

ankit-canyon avatar Apr 23 '25 17:04 ankit-canyon

Please update the package to use the latest version, then check to see if all styles are still being applied consistently and correctly.

https://github.com/canyongbs/filament-tiptap-editor/releases/tag/1.2.4

Done ! I updated the package in composer.json and verified everything is working and new styles are applying as well.

ankit-canyon avatar May 06 '25 13:05 ankit-canyon

The text sizes for the emails being sent are not consistent with the sizes in the editor or the infolist. Please ensure that all text, including all headings and paragraphs, match the size of the text in the editor. Please check your own screenshots on Jira to see the discrepancies.

For example, in the infolist h1 is 30px, but the email sends it as 18px. And the paragraphs in the infolist are 16px but 24px in the email.

Yep ! done and updated the screenshot.

ankit-canyon avatar May 09 '25 11:05 ankit-canyon

The text sizes for the emails being sent are not consistent with the sizes in the editor or the infolist. Please ensure that all text, including all headings and paragraphs, match the size of the text in the editor. Please check your own screenshots on Jira to see the discrepancies.

For example, in the infolist h1 is 30px, but the email sends it as 18px. And the paragraphs in the infolist are 16px but 24px in the email.

for the headings it's fixed but for paragraph it's 16px already on both end.

ankit-canyon avatar May 09 '25 11:05 ankit-canyon

Please retry analysis of this Pull-Request directly on SonarQube Cloud

sonarqubecloud[bot] avatar May 13 '25 10:05 sonarqubecloud[bot]

Please retry analysis of this Pull-Request directly on SonarQube Cloud

cc @Orrison

danharrin avatar May 13 '25 10:05 danharrin