ruby-readability icon indicating copy to clipboard operation
ruby-readability copied to clipboard

Image URLs which are not FQDN and have no size are missed by images()

Open pagojo opened this issue 10 years ago • 2 comments

eg.,

...
<div id="page">

<div class="article-img">
<img src="/v9/images/1x1-white.jpg" width="660" height="317" alt="iPhone Plus" class="lazy" data-original="/iphoneplus-130205.jpg"><noscript><img src="/iphoneplus-130205.jpg"></noscript>
</div>
<div class="article-img">
<img src="/plus-130906.jpg">
</div>
...

will only return /v9/images/1x1-white.jpg when images() is called.

However, if images_with_fqdn_uris!("http://bla.com") is called then subsequent calls to images() will return an array with all image URLs (fully qualified with http;//bla.com).

Now the question is, what the desired behaviour should be?

pagojo avatar Aug 18 '14 11:08 pagojo

I suspect you generally want fqdns always.

cantino avatar Aug 18 '14 18:08 cantino

Thanks, I couldn't get an image I knew was there either - wouldn't have thought of putting the FQDNs in

pjscopeland avatar Mar 17 '15 00:03 pjscopeland