mcfly icon indicating copy to clipboard operation
mcfly copied to clipboard

Visibility Issue with colorscheme

Open waivek opened this issue 2 years ago • 5 comments

mcfly

The menu contrast is difficult to read. The first match blends in.

waivek avatar Jul 03 '23 13:07 waivek

Along the same lines, is there an option to expand (suggest) a command in place of incompletely typed one? I.e. as in the screenshot above, instead of a typed portion python the command line would've python test.py as it is the currently selected suggestion in the history menu. This would make transition from ctrl-r to McFly easier and (imho) make McFly even more user friendly.

Thanks for your time!

movy avatar Feb 17 '25 16:02 movy

@movy Hitting tab accepts the command onto the command line for editing. Is this what you mean?

@waivek Is this the default color scheme or one you've modified?

cantino avatar Feb 17 '25 18:02 cantino

@cantino , below are outputs from vanilla ctrl+r and McFly for typed pyt sequence:

Image

Image

With ctrl-r the whole suggested history item is already in the command line after three key presses, while in McFly we have to switch our attention to the history menu to make sure the command selected is the one we're after. Usually #1 McFly's suggestion is correct, but my guess is that some (many?) long-time ctrl-r users expect to see the suggestion right in the command line to avoid looking down the history menu.

Having the history menu is SUPER nice, don't get me wrong, I just think these two modes (in-line suggestion as we type + history menu) can co-exists for better UX.

movy avatar Feb 18 '25 04:02 movy

Ah, I understand now. So in your example the command line would show "python scripts/build_locally.py" with pyt visible / underlined and the rest faded out? I think this might be a stylistic thing since I think I'd find that distracting, but we could add it as an optional feature if someone wants to implement it.

cantino avatar Feb 18 '25 18:02 cantino

something like that, yes. Basically, it allows to see the selected command without switching focus to the menu. I have never used Rust, do you think GPT can help here? :)

movy avatar Feb 19 '25 11:02 movy