mcfly icon indicating copy to clipboard operation
mcfly copied to clipboard

Published 20 hours ago • verified publisher icon cantino

Don't create a tarbomb

Open barmic opened this issue 4 years ago • 2 comments

tarbomb (archive without folder) is generaly a bad practice.

Instead of:

  • mcfly
  • mcfly.bash
  • mcfly.fish
  • mcfly.zsh

this will create:

  • mycfly
    • mcfly
    • mcfly.bash
    • mcfly.fish
    • mcfly.zsh

I'm not sure of all impact of it (for hombrew for example).

barmic avatar Apr 08 '21 06:04 barmic

Thanks @barmic! However, I think this might break Homebrew and users' install scripts.

cantino avatar Apr 19 '21 00:04 cantino

@barmic if you still have the energy to look at it, it would be great if this PR also included the changes to the Homebrew recipe and install documentation to go with the changed folder structure in the zip file.

necaris avatar Sep 21 '22 15:09 necaris