onnxruntime-silicon icon indicating copy to clipboard operation
onnxruntime-silicon copied to clipboard

Onnxruntime 1.14.2

Open verback2308 opened this issue 2 years ago • 6 comments

An unofficial fork onnxruntime 1.14.1 with memory leak fixes and build improvements for M1/M2 chips. Up to 1.14.1 (including) builds had a memory leak issue, which was fixed in the next version. But starting from 1.15.0, they have some graphic glitches and library is not suitable at all. https://github.com/s0md3v/roop/issues/321#issuecomment-1585507301

@cansik

PR was re-created due to a typo in a branch name in the previous ones #5

verback2308 avatar Jun 14 '23 21:06 verback2308

Merge it please

koushyk avatar Jun 30 '23 18:06 koushyk

Thank you for the PR.

Merging it into the main branch does not really make sense because the basic functionality of the script is not changed. But I can merge it into a new branch especially for this version, because the main changes have been done in your onnxruntime fork.

I have prebuilt the wheels for v1.14.2, could you please give it a try and tell me if it works? If yes, I can publish them on pypi as well.

cansik avatar Jun 30 '23 22:06 cansik

@cansik I suggest the community to send you a GIT patch file including the temporary changes, so you can apply it to your build scripts.

Then you can automatically create the official and community version from the upstream repository.

That would be more transparent for everyone as the changes are not hidden in some third party fork.

Your versioning is wrong, you need to add a suffix instead of adding a patch version. Therefore 1.14.1-ce (community edition) would follow semantic versioning as you need to keep align with the upstream.

henryruhs avatar Jul 02 '23 09:07 henryruhs

@henryruhs I have already pre-built the wheels and created a branch for it. No need for sending patch files manually around. What needs to be done is to test the version now by someone who is able to reproduce the bug.

cansik avatar Jul 02 '23 09:07 cansik

I can check it, can you please send me whl for python3.9?

h0x91b avatar Jul 02 '23 18:07 h0x91b

Thank you for the PR.

Merging it into the main branch does not really make sense because the basic functionality of the script is not changed. But I can merge it into a new branch especially for this version, because the main changes have been done in your onnxruntime fork.

That is exactly what I want to ask you.

I have prebuilt the wheels for v1.14.2, could you please give it a try and tell me if it works? If yes, I can publish them on pypi as well.

I've tested "onnxruntime_silicon-1.14.2-cp310-cp310-macosx_12_0_arm64.whl" - everything is good. No memory leaks, no blurred faces. It's the same as my local build.

Thank you.

verback2308 avatar Jul 03 '23 08:07 verback2308