dolphin-platform icon indicating copy to clipboard operation
dolphin-platform copied to clipboard

dolphinPlatform.servletMapping not working

Open hendrikebbers opened this issue 8 years ago • 2 comments

🆕🐥:dog: First Timers Only

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

:space_invader: Description of the issue

Defining a Spring boot server with the following property in application.properties: dolphinPlatform.servletMapping=/remoting

Defining a JavaFX client that extends DolphinPlatformApplication and define getURL() as: http://localhost:8080/remoting

The app won't run. The client showsconnection is broken as error.

By removing the property on the server and defining the url on the client as http://localhost:8080/dolphin everything works fine

📋 Step by Step

  • 🙋 Claim this issue: Comment below.
  • 🔄 replace the up for grabs label with in progress.
  • :fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
  • :arrow_heading_down: check out the forked repository
  • :twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
  • 💾 Commit your changes.
  • 🔀 Start a Pull Request.
  • 🏁 Done 👍 Ask in comments for a review :)
  • 🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
  • :boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
  • :bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions

You can join our community chat at Slack

hendrikebbers avatar Mar 22 '18 10:03 hendrikebbers

Hey! Can I try this issue please? Plus how can I change the label for this?

shamlymackey avatar Apr 03 '18 00:04 shamlymackey

@shamlymackey sure :)

hendrikebbers avatar Apr 03 '18 05:04 hendrikebbers