dolphin-platform icon indicating copy to clipboard operation
dolphin-platform copied to clipboard

Null Pointer Exceptions

Open Jarota opened this issue 8 years ago • 5 comments

🆕🐥:dog: First Timers Only

This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

:space_invader: Description of the issue

See this PullRequest: #666

There's a number of null pointer exceptions when building ( ./gradlew clean build ) I've attached a file with the build output, containing the exceptions. buildOutput.txt

The interesting part of the log is this one:

2017-10-19 06:11:11.395 WARN 5294 --- [ Test worker] org.reflections.Reflections : could not create Vfs.Dir from url. ignoring the exception and continuing

 either use fromURL(final URL url, final List<UrlType> urlTypes) or use the static setDefaultURLTypes(final List<UrlType> urlTypes) or addDefaultURLTypes(UrlType urlType) with your specialized UrlType.
 	at org.reflections.vfs.Vfs.fromURL(Vfs.java:109) ~[reflections-0.9.10.jar:na]
 	at org.reflections.vfs.Vfs.fromURL(Vfs.java:91) ~[reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.scan(Reflections.java:237) [reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.scan(Reflections.java:204) [reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.<init>(Reflections.java:129) [reflections-0.9.10.jar:na]
 	at com.canoo.dp.impl.server.scanner.DefaultClasspathScanner.<init>(DefaultClasspathScanner.java:76) [dolphin-platform-server-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.dp.impl.server.scanner.DefaultClasspathScanner.<init>(DefaultClasspathScanner.java:43) [dolphin-platform-server-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.TestConfiguration.<init>(TestConfiguration.java:74) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap.createTestConfiguration(DolphinPlatformSpringTestBootstrap.java:52) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap$$EnhancerBySpringCGLIB$$c15ec7c7.CGLIB$createTestConfiguration$0(<generated>) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap$$EnhancerBySpringCGLIB$$c15ec7c7$$FastClassBySpringCGLIB$$b7cd71a7.invoke(<generated>) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]

It looks like this is related to an issue of the reflections lib. Anyway we should try to handle this one better.

📋 Step by Step

  • 🙋 Claim this issue: Comment below.
  • 🔄 replace the up for grabs label with in progress.
  • :fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
  • :arrow_heading_down: check out the forked repository
  • :twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
  • 💾 Commit your changes.
  • 🔀 Start a Pull Request.
  • 🏁 Done 👍 Ask in comments for a review :)
  • 🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
  • :boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
  • :bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform

🤔❓ Questions

You can join our community chat at Slack

Jarota avatar Oct 19 '17 13:10 Jarota

The interesting part of the log is this one:

2017-10-19 06:11:11.395 WARN 5294 --- [ Test worker] org.reflections.Reflections : could not create Vfs.Dir from url. ignoring the exception and continuing

 either use fromURL(final URL url, final List<UrlType> urlTypes) or use the static setDefaultURLTypes(final List<UrlType> urlTypes) or addDefaultURLTypes(UrlType urlType) with your specialized UrlType.
 	at org.reflections.vfs.Vfs.fromURL(Vfs.java:109) ~[reflections-0.9.10.jar:na]
 	at org.reflections.vfs.Vfs.fromURL(Vfs.java:91) ~[reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.scan(Reflections.java:237) [reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.scan(Reflections.java:204) [reflections-0.9.10.jar:na]
 	at org.reflections.Reflections.<init>(Reflections.java:129) [reflections-0.9.10.jar:na]
 	at com.canoo.dp.impl.server.scanner.DefaultClasspathScanner.<init>(DefaultClasspathScanner.java:76) [dolphin-platform-server-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.dp.impl.server.scanner.DefaultClasspathScanner.<init>(DefaultClasspathScanner.java:43) [dolphin-platform-server-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.TestConfiguration.<init>(TestConfiguration.java:74) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap.createTestConfiguration(DolphinPlatformSpringTestBootstrap.java:52) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap$$EnhancerBySpringCGLIB$$c15ec7c7.CGLIB$createTestConfiguration$0(<generated>) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]
 	at com.canoo.impl.dp.spring.test.DolphinPlatformSpringTestBootstrap$$EnhancerBySpringCGLIB$$c15ec7c7$$FastClassBySpringCGLIB$$b7cd71a7.invoke(<generated>) [dolphin-platform-spring-controller-tester-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT]

It looks like this is related to an issue of the reflections lib. Anyway we should try to handle this one better.

hendrikebbers avatar Oct 23 '17 07:10 hendrikebbers

See related issue for reflections library https://github.com/ronmamo/reflections/issues/204

hendrikebbers avatar Oct 23 '17 07:10 hendrikebbers

I can take this, if it's alright with you.

mohamadLy avatar Dec 16 '17 22:12 mohamadLy

Absolutely, work away! :)

On 16 Dec 2017 10:44 pm, "Mohamadou Ly" [email protected] wrote:

I can take this, if it's alright with you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/canoo/dolphin-platform/issues/685#issuecomment-352217159, or mute the thread https://github.com/notifications/unsubscribe-auth/AfBWDPZL_NJ4tgbsLdRWXsMfHEv2FtrUks5tBEfdgaJpZM4P_O9T .

Jarota avatar Dec 17 '17 09:12 Jarota

@Jarota thanks for the opportunity

mohamadLy avatar Dec 17 '17 19:12 mohamadLy