dolphin-platform
dolphin-platform copied to clipboard
Adding native build support to client in maven archetype
🆕🐥:dog: First Timers Only
This issue is reserved for people who never contributed to Open Source before. We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
:space_invader: Description of the issue
Currently the pom of the client module do not provide a native build support. This can easily be done by adding the javafx-maven-plugin
plugin to the build. Here is an example how the plugin can be used:
<plugin>
<groupId>com.zenjava</groupId>
<artifactId>javafx-maven-plugin</artifactId>
<version>8.7.0</version>
<configuration>
<mainClass>PATH.TO.MAIN.CLASS</mainClass>
<vendor>Canoo Engineering AG</vendor>
<appName>JavaFX-Application</appName>
<needShortcut>true</needShortcut>
<needMenu>true</needMenu>
</configuration>
<executions>
<execution>
<id>create-jfxjar</id>
<phase>package</phase>
<goals>
<goal>build-jar</goal>
</goals>
</execution>
<execution>
<id>create-native</id>
<phase>package</phase>
<goals>
<goal>build-native</goal>
</goals>
</execution>
</executions>
</plugin>
This issue is related to the maven archetype for the Dolphin Platform that can be found here: https://github.com/canoo/dolphin-platform-spring-boot-archetype
📋 Step by Step
- 🙋 Claim this issue: Comment below.
- 🔄 replace the up for grabs label with in progress.
- :fork_and_knife: fork the repository in github by simply clicking the 'fork' button.
- :arrow_heading_down: check out the forked repository
- :twisted_rightwards_arrows: create a feature branch for the issue. We do not have any naming definition for branches.
- 💾 Commit your changes.
- 🔀 Start a Pull Request.
- 🏁 Done 👍 Ask in comments for a review :)
- 🔬 If the reviewer find some missing peaces or a problem he will start a discussion with you and describe the next steps how the problem can be solved.
- :boom: you did it! We will merge the fix in the master of the Dolphin Platform project.
- :bouquet: Thanks, thanks, thanks for being part as an open source contributor for Dolphin Platform
🤔❓ Questions
You can join our community chat at Slack
can I work on this issue @hendrikebbers
@codedsun sure :)
@hendrikebbers Guide me for the pom file and where the following code is to be added. Thanks.
@codedsun have a look at this repository https://github.com/canoo/dolphin-platform-spring-boot-archetype
It is a maven archetype. If you are not familiar with archetypes check this doc: http://maven.apache.org/guides/mini/guide-creating-archetypes.html
@hendrikebbers, hello I need to ask where to add this code?
@codedsun I already added the link to the repo? What exactly is your problem? Never worked on an maven archetype?
nopes :(
I have to add this whole code as it is to pom.xml?