dolphin-platform icon indicating copy to clipboard operation
dolphin-platform copied to clipboard

React on communication on a background thread

Open hendrikebbers opened this issue 8 years ago • 2 comments

Currently the ClientDolphin provides the following method: void send(String commandName, OnFinishedHandler onFinished = null) By using this method the OnFinishedHandler is always called on the UI thread. Since this is great for mostly all use cases there are some special cases that need a different handling. Currently the biggest problem is a logout method in JavaFX that will be called on the Application.stop() method. By doing so the OnFinishedHandler will never be called since JavaFX has already stopped. For this special type we need a callback in a background thread. Maybe the send methods can return CompletableFuture<Void>.

hendrikebbers avatar Jul 13 '16 10:07 hendrikebbers

PR https://github.com/canoo/dolphin-platform/pull/356 prepares the code base for this change

hendrikebbers avatar Feb 14 '17 07:02 hendrikebbers

PR https://github.com/canoo/dolphin-platform/pull/358 prepares the code base for this change

hendrikebbers avatar Feb 15 '17 09:02 hendrikebbers