vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

[block margin amendment]: <Basic section>

Open kim-isaac opened this issue 3 months ago • 2 comments

Component/pattern to amend

Basic section

Visual

Remove shallow bottom margin from these three blocks:

Image Image Image

Context

In what context does your amendment solve a problem?

Concept of blocks

  • Blocks in the Basic Section is a flexible content unit (e.g. text, image, logo blocks, list, CTA) placed inside the section’s items, with optional padding control to adjust spacing without affecting the whole pattern.

Issue

  • Some components (three in this case) come with baked-in shallow margin.
  • This makes it impossible to adjust spacing at the pattern level, which makes duplicated spacing and limits flexibility.

Impact on existing pages

  • If we remove the padding directly from the components, it could cause glitches on existing pages where those components are already in use.

Solution

  • Remove bottom margin from the block
  • In the Basic Section, blocks can be set to padding: shallow to control spacing around items, so it is more appropriate to manage spacing at the pattern level. Image

Result

  • Spacing can be adjusted without breaking the pattern
  • When a block is placed at the bottom of a section, it avoids duplicated spacing with the section’s own bottom padding.
Image

kim-isaac avatar Sep 02 '25 13:09 kim-isaac