vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Docs reference non-existing setting font-base-size

Open apollo13 opened this issue 1 year ago • 3 comments

Describe the bug

https://vanillaframework.io/docs/settings/font-settings references $font-base-size, but I can only find

$base-font-sizes: (
  base: 1rem,
  large: $font-size-largescreen,
) !default;

in the source.

apollo13 avatar Oct 10 '24 10:10 apollo13

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15777.

This message was autogenerated

Thanks @apollo13! Seems like we missed that when we were refactoring the font variables in the past.

Indeed font sizes are now provided by this map, with one base value and one we use on very large screens.

bartaz avatar Oct 10 '24 13:10 bartaz

Hi! I'd like to work on this issue. Could I please be assigned to it? I'll update the documentation to correctly reference $base-font-sizes instead of the non-existent $font-base-size. Thank you!

Nayab-Gauhar avatar Oct 31 '25 13:10 Nayab-Gauhar