vanilla-framework
vanilla-framework copied to clipboard
Move search into the reduced navigation
Done
[List of work items including drive-bys]
Fixes [list issues/bugs if needed]
QA
- Open demo
- [Add QA steps]
- Review updated documentation:
- [List any updated documentation for review]
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
- [ ] PR should have one of the following labels to automatically categorise it in release notes:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.
- [ ] Vanilla version in
package.jsonshould be updated relative to the most recent release, following semver convention:- if CSS class names are not changed it can be bugfix relesase (x.x.X)
- if CSS class names are changed/added/removed it should be minor version (x.X.0)
- see the wiki for more details
- [ ] Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
Screenshots
[if relevant, include a screenshot or screen capture]
LGTM! An unrelated note, where did we land on the position of the two logo texts. It looks a little strange as it:
@petesfrench That's where it landed. To avoid misalignments, or changing it based on having mobile menu open etc, Lyubo decided to just move it to the position where it aligns with other logo text (and menu items) by default. So this is as expected.
