vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Quote Wrapper Pattern

Open jmuzina opened this issue 1 year ago • 3 comments

Done

Adds quote wrapper pattern per Figma

Fixes WD-12811

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • [ ] PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • [ ] Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • [ ] Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

jmuzina avatar Jul 01 '24 21:07 jmuzina

Will adjust the top padding on the quote citation tomorrow per comment from @lyubomir-popov

jmuzina avatar Jul 01 '24 21:07 jmuzina

Blocked pending merge of #5196 to add in the CTA block, everything else is ready

jmuzina avatar Jul 02 '24 19:07 jmuzina

This is on hold until completion of Hero HOC - we're already working on two HOCs, three is pushing it :)

Leaving a placeholder quote wrapper macro here as a reminder for myself to implement this with a macro when I can pick this up again

jmuzina avatar Jul 19 '24 20:07 jmuzina

There were some changes to this pattern according to Lyubo, not fully speced out yet. So need to put this one on hold.

@jmuzina Now that we have a new approach to building and documenting patterns, I'll let you decide if you think it's worth keeping this PR and updating it later, or just closing it and starting fresh when the pattern is ready to be worked on.

bartaz avatar Aug 02 '24 09:08 bartaz

There were some changes to this pattern according to Lyubo, not fully speced out yet. So need to put this one on hold.

@jmuzina Now that we have a new approach to building and documenting patterns, I'll let you decide if you think it's worth keeping this PR and updating it later, or just closing it and starting fresh when the pattern is ready to be worked on.

I can close the PR for housekeeping reasons and pick this back up fresh when it's specced out more

jmuzina avatar Aug 02 '24 12:08 jmuzina