vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Limit all headings to 40rem, same as paragraph text

Open lyubomir-popov opened this issue 1 year ago • 5 comments

We've received complaints that headings take up more horizontal width than text in the documentation layout, where text is not constrained to narrow columns, but spans the full available width until it hits the 40em max-width. For bigger font-size headings, that's a lot wider than surronding paragraphs. I propose we limit everything to 40rem as opposed to 40em, so things look tidier.

lyubomir-popov avatar Jun 28 '24 15:06 lyubomir-popov

You know it means all the headings everywhere will be restricted? Is that what we want?

image

It will break existing headings in unexpected ways (if they have hardcoded break lines): image

bartaz avatar Jun 28 '24 15:06 bartaz

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15288.

This message was autogenerated

@lyubomir-popov is this something we still want to do (knowing that it may affect many existing headings in unexpected ways)?

bartaz avatar Sep 25 '24 07:09 bartaz

good point, hadn't considered that. What would you recommend for the docs problem specifically? Can we have maybe recommend using the utility (.p-max-width IIRC) on the parent?

lyubomir-popov avatar Sep 27 '24 10:09 lyubomir-popov

good point, hadn't considered that. What would you recommend for the docs problem specifically? Can we have maybe recommend using the utility (.p-max-width IIRC) on the parent?

May be a good call. We already use it to limit width of lists, so we can include headings into that.

I'm triaging it to be fixed this way then.

bartaz avatar Sep 27 '24 11:09 bartaz