Positive button's focus in invisible on dark theme

[bartaz]

Describe the bug

https://vanillaframework.io/docs/examples/patterns/buttons/dark

Focus color for positive button is very dark and invisible in dark theme.

[jmuzina]

I think we can try to address this with new variable introduced by merging of #5192 , correct?

[pastelcyborg]

I discovered this during my focus variable work, but left it alone, as it used a different variable. To be honest, I find the fact that the outline is black under any circumstances, dark or not, kind of odd. Maybe we could revisit this?

[bartaz]

I discovered this during my focus variable work, but left it alone, as it used a different variable. To be honest, I find the fact that the outline is black under any circumstances, dark or not, kind of odd. Maybe we could revisit this?

I believe it was because it was hard to find any other colour with enough contrast against both background and the button colour to comply with accessibility requirements.

[pastelcyborg]

Good to know, thanks @bartaz. Yeah, we should come up with a new color for this on dark theme, even if it's a grayscale shade.