vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Make modal padding match grid row padding across all breakpoints

Open lyubomir-popov opened this issue 1 year ago • 4 comments

Component/pattern to amend

The modal's padding is set to a value of 16px, while the grid side padding ($grid-margin-width IIRC) changes on breakpoints. This makes it difficult to align stuff inside the modal with the page content underneath. What would help is to make sure the panel has the e xact same padding-left and padding right.

Visual

image

In the screenshot above, the underlying rows ion the page are highlgihted by the browser's visualisation. That's what we're trying to align and it proves a little tricky atm. Relevant pr: image

Context

In what context does your amendment solve a problem?

lyubomir-popov avatar Jun 14 '24 10:06 lyubomir-popov

Modal completely covers the page, puts an overlay on top of it. The width of modal may differ from the width of the page on smaller screens. Does it really matter to align it to the grid that is not visible?

bartaz avatar Jun 14 '24 11:06 bartaz

@danielmutis @lyubomir-popov I'm not sure what are expected next steps for this?

bartaz avatar Sep 25 '24 07:09 bartaz

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15286.

This message was autogenerated

I think the request is valid. There are short modals, and you could see parts of the page under the fade.

lyubomir-popov avatar Sep 27 '24 10:09 lyubomir-popov