p-modal__header need overflow:auto to prevent margin collapse

[lyubomir-popov]

Describe the bug

Notice the horizontal rule is placed too close to the title, the margin-bottom of which is ignored due to not tha parent not having overflow-y:auto

see how the <hr> is at t he top of the orange margin ^

To Reproduce

Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior

A clear and concise description of what you expected to happen.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context

Add any other context about the problem here.

[bartaz]

Line sits correcty under the h2 above it:

Overflow won't change anything here. The line that you mention is a pseudo border on the bottom on header element. This header element has it's bottom margin, this margin will always be below the border (or below the ::after element, as in this case).

Do we actually need more spacing between h2 and the line? In such case h2 should have bigger bottom margin, or header needs some bottom padding.

[bartaz]

This seems to work as expected. Please reopen if needed.

[syncronize-issues-to-jira[bot]]

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15282.

This message was autogenerated