vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Adding grid usage explanation to app layout when l-nav is in is-collapsed state.

Open camillet16 opened this issue 1 year ago • 5 comments

Describe the bug

Lacking info on Vanilla docs

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'Vanilla docs app layout'
  2. Missing content

Expected behavior

Show how grids work when l-nav is in an is-collapsed state and when l-aside is a panel not a slide over.

Screenshots

  • When l-aside is a panel not a slide over Screenshot 2024-03-25 at 5 50 56 PM

  • When l-nav is-collapsed - does the grid stretch across the screen or does it float left? Screenshot 2024-03-25 at 5 54 12 PM

  • OS: MacOS

  • Browser: Chrome

  • Version: Latest

Add any other context about the problem here. Vanilla working group help :)

camillet16 avatar Mar 25 '24 16:03 camillet16

From WG:

The mafia will explore what the behaviour should be and benchmark existing implementations. The implementation is intended to have a max width which will stay left aligned when the side nav is collapsed and the window is wider than this maximum.

danielmutis avatar May 29 '24 09:05 danielmutis

From code point of view we could explore https://caniuse.com/css-container-queries This seems to be supported in modern browsers and would allow to make grid responsive based on panel size rather than screen size

bartaz avatar May 29 '24 09:05 bartaz

WG:

  • Lyubo: the content should expand until it's max width and from that point on it could be centred.
  • When there is a side panel, the side panel should have a fixed width and continue to be attached to the right edge of the page.
  • Wide screens are typically not used like this, so with these two approaches we cover the use case without necessarily designing for this situation.

danielmutis avatar Sep 18 '24 09:09 danielmutis

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-14982.

This message was autogenerated

Triage: we need to review/update current docs and examples. This is relevant to current codebase.

bartaz avatar Sep 25 '24 07:09 bartaz