vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Adding breakpoint helpers

Open goulinkh opened this issue 3 years ago • 2 comments

During the migration to Vanilla 3 on Juju dashboard I had an issue where the breakpoint medium doesn't exist anymore, I had an option to manually define the breakpoint medium but I feel that it's fighting against the flow of the Vanilla lib so instead I decided to follow the docs and use a media selector that does this mobile < ... < large.

That made my SCSS code somewhat unreadable easily by others so during my research on fixing, I stumbled across this article: https://css-tricks.com/approaches-media-queries-sass and I found this one easy to write/use/read: Landon Schropp’s technique.

Here is how our solution look like: https://github.com/canonical/jaas-dashboard/blob/05c9737e7251e77df8583ac4dffefbf7466c5b4f/src/scss/_breakpoints.scss

It maybe worth it to add this in the Vanilla library!

goulinkh avatar Oct 13 '22 20:10 goulinkh

Triage: for consideration in new architecture

bartaz avatar Sep 24 '24 08:09 bartaz

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-15213.

This message was autogenerated