vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

feat: expandable side navigation

Open petermakowski opened this issue 3 years ago • 2 comments

Done

  • add expandable side navigation

Fixes https://github.com/canonical/vanilla-squad/issues/1420

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • [x] PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • [ ] Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • [ ] Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • [ ] Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

petermakowski avatar Aug 17 '22 08:08 petermakowski

Demo starting at https://vanilla-framework-4536.demos.haus

webteam-app avatar Aug 17 '22 08:08 webteam-app

LGTM 👍

lyubomir-popov avatar Aug 18 '22 14:08 lyubomir-popov

I think we should remove the "New" label and warning icon from this example.

We don't know if and how it would work with expand button, and we don't need to support that. Let's not give an impression that we do. image

bartaz avatar Aug 23 '22 07:08 bartaz