vanilla-framework icon indicating copy to clipboard operation
vanilla-framework copied to clipboard

Fetch segmented control design guidelines

Open bethcollins92 opened this issue 2 years ago • 2 comments

Done

  • Fetch segmented control guidelines from discourse and display in docs

Fixes #1353

QA

  • Open demo
  • Check the design guidelines appear as expected

Segmented control: https://vanilla-framework-4445.demos.haus/design/patterns/segmented-control Switch: https://vanilla-framework-4445.demos.haus/design/patterns/switch Slider: https://vanilla-framework-4445.demos.haus/design/patterns/slider Matrix: https://vanilla-framework-4445.demos.haus/design/patterns/matrix Chips: https://vanilla-framework-4445.demos.haus/design/patterns/chip Badge: https://vanilla-framework-4445.demos.haus/design/patterns/badge Contextual menu: https://vanilla-framework-4445.demos.haus/design/patterns/contextual-menu Button: https://vanilla-framework-4445.demos.haus/design/patterns/buttons

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • [x] PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • [x] Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • [x] Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • [x] Documentation side navigation should be updated with the relevant labels.

Screenshots

[if relevant, include a screenshot or screen capture]

bethcollins92 avatar Apr 29 '22 08:04 bethcollins92

Demo starting at https://vanilla-framework-4445.demos.haus

webteam-app avatar Apr 29 '22 08:04 webteam-app

Hi @danielmutis, I've done a draft PR so when you update the segmented control guidelines on discourse you can see the changes in the demo here.

bethcollins92 avatar May 04 '22 10:05 bethcollins92

A historical moment.

Now, once we merged #4927 that migrated design guidelines directly to Vanilla docs markdown files, we can finally safely retire this branch and PR. After almost 2 years.

respect

bartaz avatar Apr 05 '24 12:04 bartaz